Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span.is_recording() now based off self._end_time and returns False if… #1289

Merged
merged 3 commits into from
Oct 29, 2020
Merged

Span.is_recording() now based off self._end_time and returns False if… #1289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6d667cd
Span.is_recording() now based off self._end_time and returns False if…
robwknox Oct 27, 2020
e1f116f
CHANGELOG entry
robwknox Oct 27, 2020
1b9a9a0
Merge branch 'master' into 1243_isrecording_becomes_false_after_end_v2
Oct 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion opentelemetry-sdk/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,10 @@
([#998](https://github.com/open-telemetry/opentelemetry-python/pull/998))
- Samplers to accept parent Context
([#1267](https://github.com/open-telemetry/opentelemetry-python/pull/1267))
- Updating status codes to adhere to spec ([#1282](https://github.com/open-telemetry/opentelemetry-python/pull/1282))
- Updating status codes to adhere to spec
([#1282](https://github.com/open-telemetry/opentelemetry-python/pull/1282))
- Span.is_recording() returns false after span has ended
([#1289](https://github.com/open-telemetry/opentelemetry-python/pull/1289))

## Version 0.14b0

Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-sdk/src/opentelemetry/sdk/trace/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -646,7 +646,7 @@ def update_name(self, name: str) -> None:
self.name = name

def is_recording(self) -> bool:
return True
return self._end_time is None

@_check_span_ended
def set_status(self, status: trace_api.Status) -> None:
Expand Down