Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add span name callback for requests instrumentation #1358

Closed
wants to merge 1 commit into from
Closed

Add span name callback for requests instrumentation #1358

wants to merge 1 commit into from

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Nov 5, 2020

@lzchen lzchen requested review from a team, owais and hectorhdzg and removed request for a team November 5, 2020 15:56
@NathanielRN
Copy link
Contributor

@lzchen The migration is complete at this point! Would you be able to make this PR in the contrib repo instead?

@codeboten codeboten added the instrumentation Related to the instrumentation of third party libraries or frameworks label Nov 5, 2020
@lzchen
Copy link
Contributor Author

lzchen commented Nov 5, 2020

Closing this and reopening in contrib repo.

@lzchen lzchen closed this Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owais owais Awaiting requested review from owais

@hectorhdzg hectorhdzg Awaiting requested review from hectorhdzg

Assignees
No one assigned
Labels
instrumentation Related to the instrumentation of third party libraries or frameworks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add hook to set custom span name in requests instrumentation
3 participants
@lzchen @NathanielRN @codeboten