Add code coverage in tests #208
Conversation
for start_time and end_time
hectorhdzg
requested review from
a-feld,
c24t,
carlosalberto,
lzchen,
Oberon00,
reyang and
toumorokoshi
as code owners
| @@ -0,0 +1,5 @@ | |||
| fixes: | |||
| - "^.*/site-packages/opentelemetry/sdk/::opentelemetry-sdk/src/opentelemetry/sdk/" | |||
There was a problem hiding this comment.
We are still testing against site-packages, apparently we want to test the package instead of the local files according to this PR #122
There was a problem hiding this comment.
@Oberon00 What was the reasoning behind removing the "-e" again? Don't we want to run unit tests against our locally changed files?
There was a problem hiding this comment.
@lzchen The -e flag was hiding issues with files that were excluded from packaging. Files were missing from the tarball / wheel files but since -e was being used, the tests were using the unpackaged files.
There was a problem hiding this comment.
It would be nice to have some configurable tox environment like tox -e py37-test --installation-mode=wheel or tox -e px37-test --with-coverage. But I don't think that is possible out of the box. Maybe we should generate tox.ini with some Jinja2 template 😆
Codecov Report
@@ Coverage Diff @@
## master #208 +/- ##
=========================================
Coverage ? 89.75%
=========================================
Files ? 33
Lines ? 1201
Branches ? 0
=========================================
Hits ? 1078
Misses ? 123
Partials ? 0Continue to review full report at Codecov.
|
|
Hello @hectorhdzg,
I found your message in Gitter only because I saw this PR. If you really wanted to contact me, why didn't you just submit a comment on #128 and even didn't mention me using |
* feat: add b3 format implementation * fix: add tests * fix: review comments and add more tests * fix: omit SAMPLED header if sampling decision is absent
This a follow up of this PR:
#128
I tried to contact Aliaksei Urbanski(Jamim) and tried to push changes to his branch with no success, so I'm creating a new PR because of this, this is addressing main concern of adding dependency on pytest, we will be using only coverage.py now