Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ext/wsgi: use current span when extracting fails #226

Conversation

mauriciovasquezbernal
Copy link
Member

If propagator.extract() returns INVALID_SPAN it means that the http headers
do not contain valid trace information, in this case use the current span as
parent.

Before this change INVALID_SPAN was being passed to create_span then all the
traces were generated with trace_id = 0x0.

If propagator.extract() returns INVALID_SPAN it means that the http headers
do not contain valid trace information, in this case use the current span as
parent.

Before this change INVALID_SPAN was being passed to create_span then all the
traces were generated with trace_id = 0x0.
@Oberon00
Copy link
Member

Oberon00 commented Oct 19, 2019

If trace-ID zero is used, that's a bug in the SDK.

EDIT: Related: #228 (comment)

@toumorokoshi
Copy link
Member

fyi discussion ticket for how to handle invalid spans: #233

Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine to merge as-is now, we can revisit after resolving #233.

Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#235 solves this instead by handling invalid contexts during span creation.

@mauriciovasquezbernal
Copy link
Member Author

Closing in favor of #235

@mauriciovasquezbernal mauriciovasquezbernal deleted the mauricio/fix_wsgi_issue branch April 14, 2020 21:51
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
… (open-telemetry#232)

* fix: enable async hooks manager in node tracer

* fix(node-tracer): set scope manager as optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants