Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attributes to aggregation constructor parameters #2676

Merged
merged 2 commits into from
May 10, 2022
Merged

Add attributes to aggregation constructor parameters #2676

merged 2 commits into from
May 10, 2022

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented May 10, 2022

Fixes #2675

@ocelotl ocelotl requested a review from a team May 10, 2022 15:38
@ocelotl ocelotl self-assigned this May 10, 2022
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label May 10, 2022
@lzchen
Copy link
Contributor

lzchen commented May 10, 2022

What's the reason for having aggregations having an attributes field? Where is this being used?

@ocelotl ocelotl enabled auto-merge (squash) May 10, 2022 16:08
@ocelotl
Copy link
Contributor Author

ocelotl commented May 10, 2022

What's the reason for having aggregations having an attributes field? Where is this being used?

It will be used later in #2658, this saves us from having to pass them around when calling collect. It also makes sense from a design perspective, every attribute set is associated 1:1 to an aggregation.

@ocelotl ocelotl merged commit a821311 into open-telemetry:main May 10, 2022
@ocelotl ocelotl deleted the issue_2675 branch May 10, 2022 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@aabmass aabmass aabmass approved these changes

@srikanthccv srikanthccv Awaiting requested review from srikanthccv

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add attributes to aggregation constructor parameters
3 participants
@ocelotl @lzchen @aabmass