-
Notifications
You must be signed in to change notification settings - Fork 649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Azure Exporters out of main repo (master) #272
Conversation
It would be good to add some reference to Azure repo in OpenTelemetry python readme or somewhere else so people are aware it exist, is there any plan for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Edit: the new repo is here: https://github.com/microsoft/opentelemetry-exporters-python.
@lzchen why not continue to use the |
@c24t |
That makes sense, but now we've got two naming conventions. I opened #283 to track this. |
FYI technically you've relicensed that code from Apache2 to MIT, which generally isn't permitted without explicit permission from the code author. I figure no one here is going to sue, but In the future we may want to consider license ramifications before moving code places. |
@toumorokoshi |
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
=======================================
Coverage 85.74% 85.74%
=======================================
Files 33 33
Lines 1620 1620
Branches 183 183
=======================================
Hits 1389 1389
Misses 184 184
Partials 47 47 Continue to review full report at Codecov.
|
@c24t Ready to merge? |
* feat(metrics): add exporter-prometheus package * doc(metrics): Add work in progress remark * fix: removed tracing, kept metrics * fix: Remove tslint.json
Addresses [#193].
Remove Azure exporters out of OpenTelemetry repos.
I've published a new Pypi package called
opentelemetry-azure-monitor-exporter
which is in a separate repository. You can see it here.@c24t I think we should deprecate the already existing package and link it to the new one.
@victoraugustolls FYI