Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix typo, wording #289

Merged
merged 4 commits into from
Nov 15, 2019
Merged

fix typo, wording #289

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1efa51d
fix typo, wording
clsung Nov 14, 2019
d514481
jaeger: fix link to opentelemetry-python repo
mauriciovasquezbernal Nov 14, 2019
bbf9a2c
add "a"
clsung Nov 15, 2019
2e6fbe3
Merge branch 'master' into fix_typo
c24t Nov 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ If you are looking for someone to help you find a starting point and be a resour
Gitter and find a buddy!

1. Join [Gitter.im](https://gitter.im) and join our [chat room](https://gitter.im/open-telemetry/opentelemetry-python).
2. Post in the room with an introduction to yourself, what area you are interested in (checks issues marked "Help Wanted"),
2. Post in the room with an introduction to yourself, what area you are interested in (check issues marked "Help Wanted"),
and say you are looking for a buddy. We will match you with someone who has experience in that area.

Your OpenTelemetry buddy is your resource to talk to directly on all aspects of contributing to OpenTelemetry: providing
Expand All @@ -37,7 +37,7 @@ You can run:
under multiple Python versions
- `tox -e docs` to regenerate the API docs
- `tox -e test-api` and `tox -e test-sdk` to run the API and SDK unit tests
- `tox -e py37-test-api` to e.g. run the the API unit tests under a specific
- `tox -e py37-test-api` to e.g. run the API unit tests under a specific
Python version
- `tox -e lint` to run lint checks on all code

Expand Down Expand Up @@ -115,7 +115,7 @@ It's especially valuable to read through the [library guidelines](https://github
OpenTelemetry is an evolving specification, one where the desires and
use cases are clear, but the method to satisfy those uses cases are not.

As such, Contributions should provide functionality and behavior that
As such, contributions should provide functionality and behavior that
conforms to the specification, but the interface and structure is flexible.

It is preferable to have contributions follow the idioms of the language
Expand Down
2 changes: 1 addition & 1 deletion ext/opentelemetry-ext-jaeger/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ gRPC is still not supported by this implementation.


.. _Jaeger: https://www.jaegertracing.io/
.. _OpenTelemetry: https://github.com/opentelemetry/opentelemetry-python/
.. _OpenTelemetry: https://github.com/open-telemetry/opentelemetry-python/

.. code:: python

Expand Down
6 changes: 3 additions & 3 deletions ext/opentelemetry-ext-wsgi/README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ OpenTelemetry WSGI Middleware

|pypi|

.. |pypi| image:: https://badge.fury.io/py/opentelemetry-wsgi.svg
:target: https://pypi.org/project/opentelemetry-opentracing-wsgi/
.. |pypi| image:: https://badge.fury.io/py/opentelemetry-ext-wsgi.svg
:target: https://pypi.org/project/opentelemetry-ext-wsgi/


This library provides a WSGI middleware that can be used on any WSGI framework
Expand All @@ -15,7 +15,7 @@ Installation

::

pip install opentelemetry-opentracing-wsgi
pip install opentelemetry-ext-wsgi


Usage (Flask)
Expand Down
2 changes: 1 addition & 1 deletion opentelemetry-api/src/opentelemetry/context/propagation/tracecontexthttptextformat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
_T = typing.TypeVar("_T")

# Keys and values are strings of up to 256 printable US-ASCII characters.
# Implementations should conform to the the `W3C Trace Context - Tracestate`_
# Implementations should conform to the `W3C Trace Context - Tracestate`_
# spec, which describes additional restrictions on valid field values.
#
# .. _W3C Trace Context - Tracestate:
Expand Down
4 changes: 2 additions & 2 deletions opentelemetry-api/src/opentelemetry/trace/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ class SpanKind(enum.Enum):
#: path latency relationship between producer and consumer spans.
PRODUCER = 3

#: Indicates that the span describes consumer receiving a message from a
#: Indicates that the span describes a consumer receiving a message from a
#: broker. Unlike client and server, there is usually no direct critical
#: path latency relationship between producer and consumer spans.
CONSUMER = 4
Expand Down Expand Up @@ -285,7 +285,7 @@ class TraceState(typing.Dict[str, str]):
"""A list of key-value pairs representing vendor-specific trace info.

Keys and values are strings of up to 256 printable US-ASCII characters.
Implementations should conform to the the `W3C Trace Context - Tracestate`_
Implementations should conform to the `W3C Trace Context - Tracestate`_
spec, which describes additional restrictions on valid field values.

.. _W3C Trace Context - Tracestate:
Expand Down