Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use importlib-metadata regardless of Python version #3217

Merged
merged 4 commits into from
Mar 16, 2023
Merged

Use importlib-metadata regardless of Python version #3217

merged 4 commits into from
Mar 16, 2023

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Mar 14, 2023

Fixes #3167

@ocelotl ocelotl requested a review from a team March 14, 2023 20:38
@ocelotl ocelotl self-assigned this Mar 14, 2023
@ocelotl ocelotl mentioned this pull request Mar 14, 2023
Closed
@ocelotl ocelotl added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Mar 15, 2023
@lzchen
Copy link
Contributor

lzchen commented Mar 15, 2023

Does this replace this: #3168

@ocelotl
Copy link
Contributor Author

ocelotl commented Mar 15, 2023

@aabmass PTAL

aabmass
aabmass approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks LGTM

opentelemetry-api/pyproject.toml Outdated Show resolved Hide resolved
opentelemetry-api/src/opentelemetry/util/_importlib_metadata.py Show resolved Hide resolved
@ocelotl ocelotl merged commit 6379c1c into open-telemetry:main Mar 16, 2023
@ocelotl ocelotl deleted the issue_3167_1 branch March 16, 2023 22:30
@whardier
Copy link

whardier commented May 4, 2023

It would be nice if we could still use a modern importlib-metadata vs ~=6.0.0

I would think ~=6.0 would work well for this eh? Any chance OP can resolve this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@aabmass aabmass aabmass approved these changes

Assignees

@ocelotl ocelotl

Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make entry_points behave the same across Python versions
4 participants
@ocelotl @lzchen @whardier @aabmass