Skip to content

Add timeout for httpTestBase #3318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jun 27, 2023
Merged

Add timeout for httpTestBase #3318

merged 6 commits into from
Jun 27, 2023

Conversation

@shalevr
Copy link
Member

@shalevr shalevr commented May 23, 2023 •
edited
Loading

Description

Add timeout for HttpTestBase so the test won't wait forever or until the manual cancelation.
Like it was here: open-telemetry/opentelemetry-python-contrib#1806

@shalevr shalevr requested a review from a team May 23, 2023 12:47
@srikanthccv srikanthccv mentioned this pull request May 27, 2023
Merged
6 tasks
@srikanthccv srikanthccv added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Jun 1, 2023
@srikanthccv
Copy link
Member

srikanthccv commented Jun 1, 2023

Could we make this timeout set in the dependent tests instead?

@shalevr
Copy link
Member Author

shalevr commented Jun 1, 2023

Could we make this timeout set in the dependent tests instead?

Sure but I think it will be better to set it once and all the tests that use httpTestBase just get it.
Instead of setting this for each test and avoiding situations the test did not set timeout.
3 seconds is long enough for a single request, I don't see a reason to wait any longer than that

@srikanthccv
Copy link
Member

srikanthccv commented Jun 2, 2023

That is a fair point

@shalevr shalevr added the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Jun 25, 2023
@ocelotl ocelotl merged commit 251b74a into open-telemetry:main Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@srikanthccv srikanthccv srikanthccv approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shalevr @srikanthccv @ocelotl