Prometheus exporter support for auto instrumentation #3413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
changed the title
aabmass
commented
Aug 24, 2023
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
aabmass
force-pushed
the
promauto-2864
branch
4 times, most recently
from
e7421e0 to
36b36a4
Compare
aabmass
force-pushed
the
promauto-2864
branch
from
36b36a4 to
286f8dd
Compare
aabmass
force-pushed
the
promauto-2864
branch
from
286f8dd to
32d35c1
Compare
aabmass
force-pushed
the
promauto-2864
branch
3 times, most recently
from
5172e4a to
37c82cc
Compare
|
Hi, thanks for this feature. I am keen to try it out. Is it just blocked by the publicAPICheck? |
|
It just needs review. The check is expected to fail here and I'll leave it failing as an FYI |
aabmass
force-pushed
the
promauto-2864
branch
from
37c82cc to
88bc4df
Compare
lzchen
reviewed
Sep 25, 2023
lzchen
reviewed
Sep 25, 2023
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Show resolved
Hide resolved
ocelotl
approved these changes
Oct 2, 2023
exporter/opentelemetry-exporter-prometheus/src/opentelemetry/exporter/prometheus/__init__.py
Outdated
Show resolved
Hide resolved
ocelotl
added
the
Approve Public API check
|
Oh I guess our release workflow covers the updating dependencies automatically. Regardless, we will be mindful to check before we make the next release. |
lzchen
approved these changes
Oct 2, 2023
Co-authored-by: Diego Hurtado <ocelotl@users.noreply.github.com>
aabmass
added
the
PR:please merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2864
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: