Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use current logger instead of global #351

Merged
merged 1 commit into from
Jan 3, 2020
Merged

Use current logger instead of global #351

merged 1 commit into from
Jan 3, 2020

Conversation

hectorhdzg
Copy link
Member

@hectorhdzg hectorhdzg requested a review from a team January 2, 2020 20:39
@codecov-io
Copy link

codecov-io commented Jan 2, 2020 •
edited
Loading

Codecov Report

Merging #351 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #351   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files          38       38           
  Lines        1839     1839           
  Branches      217      217           
=======================================
  Hits         1560     1560           
  Misses        214      214           
  Partials       65       65
Impacted Files Coverage Δ
...sdk/src/opentelemetry/sdk/trace/export/__init__.py 86.79% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4458698...8799dbe. Read the comment docs.

toumorokoshi
toumorokoshi approved these changes Jan 3, 2020
View reviewed changes
Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

@toumorokoshi toumorokoshi merged commit b72cab5 into open-telemetry:master Jan 3, 2020
@hectorhdzg hectorhdzg deleted the hectorhdzg/logger branch March 24, 2020 22:34
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
@OlivierAlbertini @danielkhan
docs(plugin-http): add option descriptions (open-telemetry#352)
998b95d 
closes open-telemetry#351

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@toumorokoshi toumorokoshi toumorokoshi approved these changes

@carlosalberto carlosalberto carlosalberto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hectorhdzg @codecov-io @carlosalberto @toumorokoshi