Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove workaround trace-context failures. #364

Merged
merged 1 commit into from
Jan 13, 2020

Conversation

dgzlopes
Copy link
Contributor

Resolves #329.

As @condorcet pointed out, the Multidict bug affecting #329 has been fixed. This PR removes the workaround added on #330 as it's no longer needed.

Signed-off-by: dgzlopes danielgonzalezlopes@gmail.com

Signed-off-by: dgzlopes <danielgonzalezlopes@gmail.com>
@dgzlopes dgzlopes requested a review from a team January 11, 2020 10:39
@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #364 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   84.82%   84.82%           
=======================================
  Files          38       38           
  Lines        1839     1839           
  Branches      217      217           
=======================================
  Hits         1560     1560           
  Misses        214      214           
  Partials       65       65

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24b3b5...7c50236. Read the comment docs.

Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since the CI is still successfully building.

@c24t c24t merged commit 908150c into open-telemetry:master Jan 13, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
closes open-telemetry#364

Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build fails: Various erros in py37-tracecontext
5 participants