Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add int and valid sequences to AttributeValue type #368

Merged

Conversation

jakemalachowski
Copy link
Contributor

Split off from #348

The OT Spec states one of the valid AttributeValue types are:

An array of primitive type values. The array MUST be homogeneous, i.e. it MUST NOT contain values of different types.

This change updates the AttributeValue type to include homogeneous sequences of str, bool, int, and float

@jakemalachowski jakemalachowski changed the title Add valid sequence values to AttributeValue type Add int and valid sequences to AttributeValue type Jan 17, 2020
@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #368 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #368   +/-   ##
=======================================
  Coverage   84.96%   84.96%           
=======================================
  Files          38       38           
  Lines        1889     1889           
  Branches      217      217           
=======================================
  Hits         1605     1605           
  Misses        219      219           
  Partials       65       65
Impacted Files Coverage Δ
opentelemetry-api/src/opentelemetry/util/types.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada53ff...33bfc00. Read the comment docs.

Copy link
Member

@toumorokoshi toumorokoshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks.

@toumorokoshi toumorokoshi merged commit 983edc6 into open-telemetry:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants