Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild docs only if source files change #380

Merged

Conversation

dgzlopes
Copy link
Contributor

This PR uses on.push.paths workflow syntax, so we don't have to rebuild the docs unless source files have changed (based on #167 from @c24t).

I think that this path-based approach triggers less unnecessary than a file-based one.

I asked for feedback on Gitter, and I would love if someone had time to throw some thoughts on this :)

Signed-off-by: Daniel González Lopes danielgonzalezlopes@gmail.com

Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
@dgzlopes dgzlopes requested a review from a team January 27, 2020 18:59
@codecov-io
Copy link

Codecov Report

Merging #380 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #380      +/-   ##
==========================================
+ Coverage   85.08%   85.22%   +0.14%     
==========================================
  Files          38       38              
  Lines        1897     1916      +19     
  Branches      225      226       +1     
==========================================
+ Hits         1614     1633      +19     
  Misses        218      218              
  Partials       65       65
Impacted Files Coverage Δ
...app/src/opentelemetry_example_app/flask_example.py 100% <0%> (ø) ⬆️
...emetry-sdk/src/opentelemetry/sdk/trace/__init__.py 90.94% <0%> (+0.06%) ⬆️
...src/opentelemetry/ext/opentracing_shim/__init__.py 95.93% <0%> (+0.17%) ⬆️
...xt-jaeger/src/opentelemetry/ext/jaeger/__init__.py 85.18% <0%> (+0.18%) ⬆️
...ts/src/opentelemetry/ext/http_requests/__init__.py 89.74% <0%> (+0.26%) ⬆️
opentelemetry-sdk/src/opentelemetry/sdk/util.py 85.88% <0%> (+0.34%) ⬆️
...opentelemetry/sdk/context/propagation/b3_format.py 87.27% <0%> (+0.48%) ⬆️
...ry-ext-wsgi/src/opentelemetry/ext/wsgi/__init__.py 68.18% <0%> (+0.58%) ⬆️
...ry-sdk/src/opentelemetry/sdk/resources/__init__.py 70.83% <0%> (+2.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccb97e5...b8cb9e0. Read the comment docs.

@dgzlopes dgzlopes changed the title Rebuild docs if source files change Rebuild docs only if source files change Jan 27, 2020
Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! This looks like a clear improvement to me.

Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

@c24t c24t merged commit 0173263 into open-telemetry:master Jan 28, 2020
@dgzlopes dgzlopes deleted the rebuild-docs-on-source-files-changes branch January 28, 2020 10:38
codeboten pushed a commit to codeboten/opentelemetry-python that referenced this pull request Jan 28, 2020
toumorokoshi pushed a commit to toumorokoshi/opentelemetry-python that referenced this pull request Feb 17, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants