-
Notifications
You must be signed in to change notification settings - Fork 631
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild docs only if source files change #380
Rebuild docs only if source files change #380
Conversation
Signed-off-by: Daniel González Lopes <danielgonzalezlopes@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 85.08% 85.22% +0.14%
==========================================
Files 38 38
Lines 1897 1916 +19
Branches 225 226 +1
==========================================
+ Hits 1614 1633 +19
Misses 218 218
Partials 65 65
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! This looks like a clear improvement to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
This PR uses
on.push.paths
workflow syntax, so we don't have to rebuild the docs unless source files have changed (based on #167 from @c24t).I think that this path-based approach triggers less unnecessary than a file-based one.
I asked for feedback on Gitter, and I would love if someone had time to throw some thoughts on this :)
Signed-off-by: Daniel González Lopes danielgonzalezlopes@gmail.com