-
Notifications
You must be signed in to change notification settings - Fork 666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Semconv generation improvements #3966
Conversation
@lmolkova please add a changelog entry, this is a good change to record |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this!
I think mypy build is complaining on the
|
the problem is that we don't know when the attribute was deprecated. I can only provide the current version ( We might add a property to track the version in the schema - open-telemetry/semantic-conventions#1117 and then we'd be able to generate accurate docstring. For the time being, I'd prefer to keep it empty and suppress the lint check. Update: |
I'm okay with ignoring the mypy warnings for deprecated. |
Description
Prepares tooling to allow #3964:
os
andnet
namespaces from being generatedType of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Answer the following question based on these examples of changes that would require a Contrib Repo Change:
The OTel specification has changed which prompted this PR to update the method interfaces of
opentelemetry-api/
oropentelemetry-sdk/
The method interfaces of
test/util
have changedScripts in
scripts/
that were copied over to the Contrib repo have changedConfiguration files that were copied over to the Contrib repo have changed (when consistency between repositories is applicable) such as in
pyproject.toml
isort.cfg
.flake8
When a new
.github/CODEOWNER
is addedMajor changes to project information, such as in:
README.md
CONTRIBUTING.md
Yes. - Link to PR:
No.
Checklist: