SDK: set sampled flag on sampling trace #407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
...after doing: diff --git a/opentelemetry-api/src/opentelemetry/trace/__init__.py b/opentelemetry-api/src/opentelemetry/trace/__init__.py
index 28c1bf40..3473361d 100644
--- a/opentelemetry-api/src/opentelemetry/trace/__init__.py
+++ b/opentelemetry-api/src/opentelemetry/trace/__init__.py
@@ -266,7 +266,9 @@ class TraceOptions(int):
return cls(cls.DEFAULT)
@classmethod
- def get_sampled(cls, other: "TraceOptions" = None) -> "TraceOptions":
+ def get_sampled(
+ cls, other: typing.Optional["TraceOptions"] = None
+ ) -> "TraceOptions":
if other is None:
return cls(cls.SAMPLED)
return cls(other | cls.SAMPLED)
( |
Codecov Report
@@ Coverage Diff @@
## master #407 +/- ##
=========================================
Coverage ? 85.86%
=========================================
Files ? 41
Lines ? 2080
Branches ? 242
=========================================
Hits ? 1786
Misses ? 223
Partials ? 71
Continue to review full report at Codecov.
|
|
@c24t done! |
ocelotl
suggested changes
Feb 11, 2020
|
LGTM 👍 |
ocelotl
approved these changes
Feb 11, 2020
c24t
changed the title
|
FYI I reworded the commit because "upon sampling decision" could be interpreted as "on making any sampling decision". |
Oberon00
reviewed
Feb 14, 2020
| @@ -511,6 +511,8 @@ def start_span( # pylint: disable=too-many-locals | |||
| ) | |||
|
|
|||
| if sampling_decision.sampled: | |||
| options = context.trace_options | trace_api.TraceOptions.SAMPLED | |||
| context.trace_options = trace_api.TraceOptions(options) | |||
There was a problem hiding this comment.
Technically, we are modifying a context here which is supposed to be immutable. Since we are the unique owner of the context here (we haven't let anyone else see it yet) that's fine, but I wonder if we should make use of __slots__ and @propertys in SpanContext.
toumorokoshi
pushed a commit
to toumorokoshi/opentelemetry-python
that referenced
this pull request
Feb 17, 2020
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
* chore: add plugin request issue template * Update .github/ISSUE_TEMPLATE/plugin_request.md Co-Authored-By: dyladan <dyladan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #400.