Remove "print(Context)" from basic tracer example #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two reasons to remove it: - Now Context is a class and it doesn't print any useful information. - We don't expect users to interact directly with the context, so avoid it.
Codecov Report
@@ Coverage Diff @@
## master #428 +/- ##
=======================================
Coverage 88.22% 88.22%
=======================================
Files 42 42
Lines 2047 2047
Branches 233 233
=======================================
Hits 1806 1806
Misses 170 170
Partials 71 71Continue to review full report at Codecov.
|
codeboten
approved these changes
Feb 18, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Printing Hello World makes more sense here 👍
toumorokoshi
approved these changes
Feb 18, 2020
Member
|
Great, thanks! |
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
closes open-telemetry#427 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two reasons to remove it: