Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infra: remove generate contrib workflows from core #4302

Merged
merged 13 commits into from
Nov 26, 2024
Merged

infra: remove generate contrib workflows from core #4302

merged 13 commits into from
Nov 26, 2024

Conversation

emdneto
Copy link
Member

@emdneto emdneto commented Nov 21, 2024 •
edited
Loading

This PR basically shifts from depending on generating workflows every time we change something in contrib to looking to contrib@main and reusing the workflow core_contrib_test.yml. With that, we only need to update contrib workflows, and there's no need to sync workflows in core anymore.

Related PR in contrib: open-telemetry/opentelemetry-python-contrib#3035

Part of #4263

@emdneto
test call worflow
fbb0fcb 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto requested a review from a team as a code owner November 21, 2024 00:53
@emdneto emdneto marked this pull request as draft November 21, 2024 00:53
@emdneto
test repo
a860068 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto
remove old contrib
578f3cd 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto closed this Nov 21, 2024
@emdneto emdneto reopened this Nov 21, 2024
@emdneto
fix names
5d9fd07 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 21, 2024
@emdneto emdneto closed this Nov 21, 2024
@emdneto emdneto reopened this Nov 21, 2024
@emdneto emdneto marked this pull request as ready for review November 21, 2024 01:35
@emdneto emdneto mentioned this pull request Nov 21, 2024
Merged
@emdneto
change name
643cd8d 
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
@emdneto emdneto changed the title test call worflow infra: remove generate contrib workflows from core Nov 21, 2024
emdneto
emdneto commented Nov 22, 2024
View reviewed changes
Copy link
Member Author

@emdneto emdneto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this is the first step of a major change we want to do that is related to have generate_workflows_lib for each repo instead of core depends on generate_workflos_lib hosted in contrib

@emdneto emdneto marked this pull request as draft November 25, 2024 11:07
@emdneto emdneto marked this pull request as ready for review November 26, 2024 00:55
@xrmx xrmx enabled auto-merge (squash) November 26, 2024 12:17
@emdneto emdneto disabled auto-merge November 26, 2024 13:07
@xrmx xrmx closed this Nov 26, 2024
@xrmx xrmx reopened this Nov 26, 2024
@xrmx
Copy link
Contributor

xrmx commented Nov 26, 2024

So in order to get this in it requires to update our branch protecting rules that are referencing the old jobs.

@xrmx xrmx merged commit 78653ef into open-telemetry:main Nov 26, 2024
353 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xrmx xrmx xrmx approved these changes

@tammy-baylis-swi tammy-baylis-swi tammy-baylis-swi approved these changes

Assignees
No one assigned
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emdneto @xrmx @tammy-baylis-swi