Skip to content

Add exporter/opentelemetry-exporter-otlp-proto-grpc to the pyright include list. Fix all lint errors in that package. #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Sep 30, 2025
Merged

Add exporter/opentelemetry-exporter-otlp-proto-grpc to the pyright include list. Fix all lint errors in that package. #4566

merged 17 commits into from
Sep 30, 2025

Conversation

@DylanRussell
Copy link
Contributor

@DylanRussell DylanRussell commented May 5, 2025

Description

Add exporter/opentelemetry-exporter-otlp-proto-grpc to the pyright include list. Fix all lint errors in that package.

Type of change

Please delete options that are not relevant.

  • [x ] Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests all pass

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • [ x] No.

Checklist:

  • [x ] Followed the style guidelines of this project
  • [x ] Changelogs have been updated
  • [ x] Unit tests have been added
  • [x ] Documentation has been updated

@DylanRussell
Add exporter/opentelemetry-exporter-otlp-proto-grpc to the pyright …
42b25e0 
…include list. Fix all lint errors in that package.
@DylanRussell DylanRussell requested a review from a team as a code owner May 5, 2025 17:57
@DylanRussell
Copy link
Contributor Author

DylanRussell commented May 5, 2025

Not sure why that docs check is failing..

@xrmx
Copy link
Contributor

xrmx commented May 6, 2025

Not sure why that docs check is failing..

You are exporting more stuff and so something must be added to the sphinx ignore list

@DylanRussell
Copy link
Contributor Author

DylanRussell commented May 6, 2025

Aha didn't know about the sphinx ignore list thanks.

What do you think of adding ExportStubT as a public symbol ? I can underscore it, but it'd be inconsistent with the existing variable names

@DylanRussell
Copy link
Contributor Author

DylanRussell commented May 14, 2025

BTW I bumped pyright up to ==1.1.400 here to get rid of the warning message asking us to upgrade it... Didn't cause any issues AFAICT...

emdneto
emdneto reviewed Sep 5, 2025
View reviewed changes
Copy link
Member

@emdneto emdneto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DylanRussell I think this is good to have. Is there anything pending here other than fixing conflicts?

@xrmx xrmx moved this to Reviewed PR that needs fixing in @xrmx's Python PR digest Sep 9, 2025
@xrmx xrmx moved this from Reviewed PR that needs fixing to Approved PRs in @xrmx's Python PR digest Sep 10, 2025
@xrmx xrmx moved this from Approved PRs to Approved PRs that need fixing in @xrmx's Python PR digest Sep 10, 2025
@DylanRussell
Copy link
Contributor Author

DylanRussell commented Sep 12, 2025

Alright I think it's good to go now.. The changing public symbols are all in the exporter mixin class, which I think it's doubtful people are using directly..

@xrmx xrmx moved this from Approved PRs that need fixes to Approved PRs in @xrmx's Python PR digest Sep 15, 2025
aabmass
aabmass approved these changes Sep 16, 2025
View reviewed changes
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ this is great thank you!

@aabmass aabmass added Skip Changelog PRs that do not require a CHANGELOG.md entry Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary labels Sep 30, 2025
@aabmass aabmass enabled auto-merge (squash) September 30, 2025 19:36
@aabmass aabmass added Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary and removed Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary labels Sep 30, 2025
@aabmass aabmass merged commit b63f643 into open-telemetry:main Sep 30, 2025
470 of 471 checks passed
@github-project-automation github-project-automation bot moved this from Approved PRs to Done in @xrmx's Python PR digest Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aabmass aabmass aabmass approved these changes

@emdneto emdneto emdneto approved these changes

@xrmx xrmx xrmx approved these changes

@lzchen lzchen lzchen approved these changes

Assignees

No one assigned

Labels

Approve Public API check This label shows that the public symbols added or changed in a PR are strictly necessary Skip Changelog PRs that do not require a CHANGELOG.md entry

Projects

@xrmx's Python PR digest
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DylanRussell @xrmx @aabmass @emdneto @lzchen