opentelemetry-sdk: be less picky about deprecated LogRecord interface #4762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All code that is emitting API LogRecords will emit this warnings because the conversion code need to pass the deprecated fields because of Event still using these fields. In the meantime we cleanup that warn only if we are not already using context.
aabmass
approved these changes
Oct 2, 2025
lzchen
approved these changes
Oct 2, 2025
emdneto
approved these changes
Oct 2, 2025
Member
emdneto
left a comment
emdneto
left a comment
There was a problem hiding this comment.
I think rebasing the branch should be enough to make CI pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All the code that is emitting API LogRecords will get these warnings because the LogRecord conversion code need to pass these deprecated fields as the Event users are still using these fields.
In the meantime we cleanup that, warn only if we are not already using context.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Contrib Repo Change?
Checklist: