Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exporter retry logic should not be the responsibility of the SDK #590

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Exporter retry logic should not be the responsibility of the SDK #590

merged 2 commits into from
Apr 20, 2020

Conversation

hectorhdzg
Copy link
Member

Updating export result enums

open-telemetry/opentelemetry-specification#511

@hectorhdzg hectorhdzg requested a review from a team April 16, 2020 19:00
c24t
c24t approved these changes Apr 16, 2020
View reviewed changes
Copy link
Member

@c24t c24t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, matches the spec changes.

codeboten
codeboten approved these changes Apr 17, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mauriciovasquezbernal mauriciovasquezbernal added the PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) label Apr 20, 2020
@c24t c24t merged commit 920b4b4 into open-telemetry:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c24t c24t c24t approved these changes

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

Assignees
No one assigned
Labels
PR:please merge This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hectorhdzg @codeboten @lzchen @c24t @mauriciovasquezbernal