Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the Resource API #61

Merged
merged 6 commits into from
Jul 29, 2019

Commits on Jul 24, 2019

  1. Adding the Resource API

    toumorokoshi committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    0554ec3 View commit details
    Browse the repository at this point in the history
  2. Resource API: unit test on empty string precedence

    When merging resources, the non-empty string value takes precedence.
    toumorokoshi committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    e16e854 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2019

  1. Moving Resource to API and SDK

    The API package should be minimal, and example implementations should
    live in SDK when possible.
    
    Fixing docstrings to match sphinx-compatible formatting.
    
    using unittest-standard asserts to adhere to conventions.
    
    switcihng from Any to object works helps pass linting and mypy
    compatibility.
    toumorokoshi committed Jul 25, 2019
    Configuration menu
    Copy the full SHA
    b95da6a View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2019

  1. Resource API: renaming DefaultResource to Resource

    The precedent that exists is to name both the interface and the
    implementation in the sdk the same. This avoids the generally
    unhelpful "Default" prefix.
    
    opentelemetry-python is standardizing on Google style docstrings. As such
    resolving formatting that is inconsistent with the style guilde.
    
    Removing init from the abstract Resource class: it does not need to be
    part of the Resource API spec. Other Resource implementations may
    consume other arguments as well.
    toumorokoshi committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    8beab78 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    389dde8 View commit details
    Browse the repository at this point in the history
  3. Fixing imports to adhere with isort

    the master branch now include isort configuration that forces one import per
    line.
    toumorokoshi committed Jul 27, 2019
    Configuration menu
    Copy the full SHA
    3c363c6 View commit details
    Browse the repository at this point in the history