Fix test failures involving contextvars. #96
Merged
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-feld
requested review from
c24t,
carlosalberto,
Oberon00 and
reyang
as code owners
Jamim
suggested changes
Aug 21, 2019
Co-Authored-By: Aliaksei Urbanski <mimworkmail@gmail.com>
Jamim
approved these changes
Aug 21, 2019
reyang
approved these changes
Aug 21, 2019
|
Thanks @a-feld! It seems to be a merge conflict. |
carlosalberto
approved these changes
Aug 21, 2019
|
Just enabled the highlighted option: |
This was referenced Aug 21, 2019
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
related to open-telemetry#96 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not exactly sure how this happened but it looks like #86 introduced a failure on master. The failure is due to the sdk test using
contextvarsto attempt to initialize the tracer.This PR removes the use of
contextvarsin the offending test.