-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Span name updated to follow semantic conventions to reduce cardinality #972
Span name updated to follow semantic conventions to reduce cardinality #972
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
Should we change this for other http client libraries too? |
It looks like aiohttp-client already does the right thing unless the configuration overrides the span_name method, did I miss any other http client libraries @lzchen? |
I think it'd be good to add the "HTTP" part in front of it for the default. |
@lzchen updated span name for aiohttp-client as well |
Description
Using the path for span names in the requests instrumentation led to high cardinality in the reported data. This changes updates the name to use the method instead as defined in the semantic conventions
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: