Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Span name updated to follow semantic conventions to reduce cardinality #972

Merged
merged 9 commits into from
Aug 18, 2020

Conversation

codeboten
Copy link
Contributor

Description

Using the path for span names in the requests instrumentation led to high cardinality in the reported data. This changes updates the name to use the method instead as defined in the semantic conventions

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Tested locally
  • Ran unit tests

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been updated

@codeboten codeboten requested a review from a team August 6, 2020 15:42
Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@lzchen
Copy link
Contributor

lzchen commented Aug 11, 2020

Should we change this for other http client libraries too?

@codeboten
Copy link
Contributor Author

It looks like aiohttp-client already does the right thing unless the configuration overrides the span_name method, did I miss any other http client libraries @lzchen?

@lzchen
Copy link
Contributor

lzchen commented Aug 14, 2020

It looks like aiohttp-client already does the right thing unless the configuration overrides the span_name method, did I miss any other http client libraries @lzchen?

I think it'd be good to add the "HTTP" part in front of it for the default.

@codeboten codeboten requested a review from lzchen August 17, 2020 19:49
@codeboten
Copy link
Contributor Author

@lzchen updated span name for aiohttp-client as well

@lzchen lzchen merged commit c9709d2 into open-telemetry:master Aug 18, 2020
srikanthccv pushed a commit to srikanthccv/opentelemetry-python that referenced this pull request Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants