Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix grpc version to previous version #975

Merged
merged 1 commit into from
Aug 6, 2020
Merged

Fix grpc version to previous version #975

merged 1 commit into from
Aug 6, 2020

Conversation

ocelotl
Copy link
Contributor

@ocelotl ocelotl commented Aug 6, 2020

Fixes #974

@ocelotl ocelotl requested a review from a team August 6, 2020 22:31
@ocelotl ocelotl self-assigned this Aug 6, 2020
codeboten
codeboten approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@codeboten codeboten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, though i'm not sure if there was a reason for the 1.27 requirement previously.

@ocelotl
Copy link
Contributor Author

ocelotl commented Aug 6, 2020

This looks fine, though i'm not sure if there was a reason for the 1.27 requirement previously.

Well, what is a reason without a matching test case? 😆

@lzchen lzchen merged commit c42c5f3 into open-telemetry:master Aug 6, 2020
@mariojonke mariojonke mentioned this pull request Aug 20, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lzchen lzchen lzchen approved these changes

@codeboten codeboten codeboten approved these changes

Assignees

@ocelotl ocelotl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GRPC instrumentation fails with 1.31.0
3 participants
@ocelotl @codeboten @lzchen