[website_docs] fix broken links, copyedits and file renames #1120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalin
requested review from
ahayworth,
arielvalentin,
dazuma,
ericmustin,
fbogsany,
mwear and
robertlaurin
as code owners
chalin
commented
Feb 3, 2022
|
|
||
| [Manual Instrumentation][manual-instrumentation] will give provide you the ability to enrich your traces with domain specific data. | ||
|
|
||
| [Automatic Instrumentation][auto-instrumentation] |
There was a problem hiding this comment.
@cartermp - this entire page talks about automatic instrumentation and that same link is given elsewhere in the page, so it seemed odd to me to mention it again here in the list of "more things to look into". Hence, I removed the reference. Thoughts?
chalin
commented
Feb 3, 2022
Comment on lines
-82
to
-86
| [Context Propagation][context-propagation] is perhaps one of the most powerful concepts in OpenTelemetry because it will upgrade your single service trace into a _distributed trace_, which makes it possible for OpenTelemetry vendors to visualize a request from end-to-end across process and network boundaries. | ||
|
|
||
| [Span Events][events] allow you to add a human-readable message on a span that represents "something happening" during its lifetime. | ||
|
|
||
| [Manual Instrumentation][manual-instrumentation] will give provide you the ability to enrich your traces with domain specific data. |
There was a problem hiding this comment.
@cartermp - note that I converted these paragraphs into a list.
This was referenced Feb 3, 2022
cartermp
approved these changes
Feb 3, 2022
|
(fyi maintainers - I hit approve since I think @chalin's changes make sense w.r.t. what we're doing with docs all-around. I recognize that this requires your approval to move forward 🙂) |
robertlaurin
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
instrumentationqualifier opentelemetry.io#997With these changes, the OTel website build is successful (i.e., #1104 is fixed):
/assign @cartermp
/cc @austinlparker