Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename CorrelationContext to Baggage #338

Merged
merged 3 commits into from
Aug 26, 2020
Merged

Rename CorrelationContext to Baggage #338

merged 3 commits into from
Aug 26, 2020

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany requested review from dazuma and mwear as code owners August 26, 2020 15:40
@fbogsany fbogsany requested a review from robertlaurin August 26, 2020 15:41
robertlaurin
robertlaurin approved these changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@robertlaurin robertlaurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller questions around leftover correlation context naming. Otherwise it looks good to me.

api/lib/opentelemetry/baggage/propagation/context_keys.rb Outdated Show resolved Hide resolved
sdk/lib/opentelemetry/sdk/baggage/manager.rb Outdated Show resolved Hide resolved
mwear
mwear approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have some comments about the header name below. The tl;dr is that the name will likely be baggage, and all lowercase, but I don't think it's final yet.

api/lib/opentelemetry/baggage/propagation/text_map_extractor.rb Outdated Show resolved Hide resolved
api/lib/opentelemetry/baggage/propagation/text_map_injector.rb Outdated Show resolved Hide resolved
@fbogsany fbogsany merged commit 1a680bb into master Aug 26, 2020
@fbogsany fbogsany deleted the baggage branch August 26, 2020 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlaurin robertlaurin robertlaurin approved these changes

@mwear mwear mwear approved these changes

@dazuma dazuma Awaiting requested review from dazuma

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fbogsany @mwear @robertlaurin