Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release: Release 9 gems #583

Closed
wants to merge 4 commits into from
Closed

Conversation

github-actions[bot]
Copy link
Contributor

This pull request prepares new gem releases for the following gems:

  • opentelemetry-api 0.12.2 (was 0.12.1)
  • opentelemetry-sdk 0.13.0 (was 0.12.1)
  • opentelemetry-common 0.13.0 (was 0.12.0)
  • opentelemetry-exporter-jaeger 0.13.0 (was 0.12.0)
  • opentelemetry-exporter-otlp 0.13.0 (was 0.12.1)
  • opentelemetry-instrumentation-mongo 0.12.1 (was 0.12.0)
  • opentelemetry-instrumentation-rack 0.12.1 (was 0.12.0)
  • opentelemetry-instrumentation-ruby_kafka 0.12.1 (was 0.12.0)
  • opentelemetry-instrumentation-sidekiq 0.13.0 (was 0.12.0)

For each gem, this pull request modifies the gem version and provides an initial changelog entry based on conventional commit messages. You can edit these changes before merging, to release a different version or to alter the changelog text.

  • To confirm this release, merge this pull request, ensuring the "release: pending" label is set. The release script will trigger automatically on merge.
  • To abort this release, close this pull request without merging.

The generated changelog entries have been copied below:


opentelemetry-api

v0.12.2 / 2021-01-29

  • FIXED: Small test fixes.

opentelemetry-sdk

v0.13.0 / 2021-01-29

  • BREAKING CHANGE: Remove MILLIS from BatchSpanProcessor vars

  • ADDED: Process.runtime resource

  • ADDED: Provide default resource in SDK

  • FIXED: Resource.merge consistency

  • FIXED: Remove MILLIS from BatchSpanProcessor vars


opentelemetry-common

v0.13.0 / 2021-01-29

  • ADDED: Add untraced wrapper to common utils

opentelemetry-exporter-jaeger

v0.13.0 / 2021-01-29

  • ADDED: Provide default resource in SDK
  • ADDED: Add untraced wrapper to common utils

opentelemetry-exporter-otlp

v0.13.0 / 2021-01-29

  • BREAKING CHANGE: Spec compliance for OTLP exporter

  • ADDED: Add untraced wrapper to common utils

  • FIXED: Spec compliance for OTLP exporter

  • FIXED: Conditionally append path to collector endpoint

  • FIXED: OTLP path should be /v1/traces


opentelemetry-instrumentation-mongo

v0.12.1 / 2021-01-29

  • FIXED: Mongo Instrumenter: Do not send nil attributes

opentelemetry-instrumentation-rack

v0.12.1 / 2021-01-29

  • FIXED: Only include user agent when present

opentelemetry-instrumentation-ruby_kafka

v0.12.1 / 2021-01-29

  • FIXED: Add minimum gem version for ruby-kafka
  • FIXED: Ruby_kafka baggage propagation
  • FIXED: Remove unused ruby-kafka events file

opentelemetry-instrumentation-sidekiq

v0.13.0 / 2021-01-29

  • ADDED: Instrument sidekiq background work
  • FIXED: Adjust Sidekiq middlewares to match semantic conventions
  • FIXED: Set minimum compatible version and use untraced helper

@@ -6,5 +6,5 @@

module OpenTelemetry
## Current OpenTelemetry version
VERSION = '0.12.1'
VERSION = '0.12.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to rant about the divergence in SDK and API version numbers, but I re-read the versioning and stability doc and this is explicitly allowed.

@robertlaurin
Copy link
Contributor

robertlaurin commented Jan 29, 2021

I added three commits to the PR to bump the dependency on common. My reason being is in this PR #580 I moved the untraced method into common.

If someone were to pull the latest version of say the OTLP exporter but not common, then the gem would run into errors as untraced would not be defined. I think my changes make sense,.

However now I'm running into issues with testing an unrelated gem (see snippet below)

Testing opentelemetry-instrumentation-active_model_serializers ...
Fetching gem metadata from https://rubygems.org/.........
Fetching gem metadata from https://rubygems.org/.
Resolving dependencies...
Bundler could not find compatible versions for gem "opentelemetry-common":
  In Gemfile:
    opentelemetry-common

    opentelemetry-sdk was resolved to 0.13.0, which depends on
      opentelemetry-common (~> 0.12.0)
Error: Process completed with exit code 6.

So my confusion here comes from the fact that my changes did not introduce this dependency issue but instead the Action that triggered this PR didn't actually run CI for itself.

image

@github-actions
Copy link
Contributor Author

WARNING: An additional commit was added while this release PR was open.
You may need to add to the changelog, or close this PR and prepare a new one.

Commit link: ccde158

Message:
fix: Jaeger ref type should be FOLLOWS_FROM (#585)

@github-actions
Copy link
Contributor Author

WARNING: An additional commit was added while this release PR was open.
You may need to add to the changelog, or close this PR and prepare a new one.

Commit link: ae4d310

Message:
fix: rename OTLP env vars SPAN -> TRACES (#584)

@fbogsany
Copy link
Contributor

Closing this - I'll cut a new release with a few additional small PRs

@fbogsany fbogsany closed this Jan 29, 2021
@github-actions github-actions bot added release: aborted Automated release was aborted and removed release: pending Automated release is pending labels Jan 29, 2021
@github-actions github-actions bot deleted the release/multi/20210129184924 branch January 29, 2021 21:23
@github-actions
Copy link
Contributor Author

Release PR closed without merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: aborted Automated release was aborted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants