feat: use Cow<'static, str> instead of &'static str

opentelemetry-api/src/global/metrics.rs

@@ -1,7 +1,10 @@
 use crate::metrics::{self, Meter, MeterProvider};
 use core::fmt;
 use once_cell::sync::Lazy;
-use std::sync::{Arc, RwLock};
+use std::{
+    borrow::Cow,
+    sync::{Arc, RwLock},
+};
 
 /// The global `Meter` provider singleton.
 static GLOBAL_METER_PROVIDER: Lazy<RwLock<GlobalMeterProvider>> = Lazy::new(|| {
@@ -26,9 +29,9 @@ impl fmt::Debug for GlobalMeterProvider {
 impl MeterProvider for GlobalMeterProvider {
     fn versioned_meter(
         &self,
-        name: &'static str,
-        version: Option<&'static str>,
-        schema_url: Option<&'static str>,
+        name: Cow<'static, str>,
+        version: Option<Cow<'static, str>>,
+        schema_url: Option<Cow<'static, str>>,
     ) -> Meter {
         self.provider.versioned_meter(name, version, schema_url)
     }
@@ -72,7 +75,7 @@ pub fn meter_provider() -> GlobalMeterProvider {
 /// If the name is an empty string, the provider will use a default name.
 ///
 /// This is a more convenient way of expressing `global::meter_provider().meter(name, None, None)`.
-pub fn meter(name: &'static str) -> Meter {
+pub fn meter(name: Cow<'static, str>) -> Meter {
     meter_provider().versioned_meter(name, None, None)
 }
 
@@ -90,9 +93,9 @@ pub fn meter(name: &'static str) -> Meter {
 /// ```
 ///
 pub fn meter_with_version(
-    name: &'static str,
-    version: Option<&'static str>,
-    schema_url: Option<&'static str>,
+    name: Cow<'static, str>,
+    version: Option<Cow<'static, str>>,
+    schema_url: Option<Cow<'static, str>>,
 ) -> Meter {
     meter_provider().versioned_meter(name, version, schema_url)
 }

opentelemetry-api/src/global/trace.rs

@@ -291,8 +291,8 @@ pub trait ObjectSafeTracerProvider {
     fn versioned_tracer_boxed(
         &self,
         name: Cow<'static, str>,
-        version: Option<&'static str>,
-        schema_url: Option<&'static str>,
+        version: Option<Cow<'static, str>>,
+        schema_url: Option<Cow<'static, str>>,
     ) -> Box<dyn ObjectSafeTracer + Send + Sync>;
 }
 
@@ -306,8 +306,8 @@ where
     fn versioned_tracer_boxed(
         &self,
         name: Cow<'static, str>,
-        version: Option<&'static str>,
-        schema_url: Option<&'static str>,
+        version: Option<Cow<'static, str>>,
+        schema_url: Option<Cow<'static, str>>,
     ) -> Box<dyn ObjectSafeTracer + Send + Sync> {
         Box::new(self.versioned_tracer(name, version, schema_url))
     }
@@ -349,13 +349,13 @@ impl trace::TracerProvider for GlobalTracerProvider {
     /// Create a versioned tracer using the global provider.
     fn versioned_tracer(
         &self,
-        name: impl Into<Cow<'static, str>>,
-        version: Option<&'static str>,
-        schema_url: Option<&'static str>,
+        name: Cow<'static, str>,
+        version: Option<Cow<'static, str>>,
+        schema_url: Option<Cow<'static, str>>,
     ) -> Self::Tracer {
         BoxedTracer(
             self.provider
-                .versioned_tracer_boxed(name.into(), version, schema_url),
+                .versioned_tracer_boxed(name, version, schema_url),
         )
     }
 }

opentelemetry-api/src/metrics/meter.rs

@@ -22,7 +22,7 @@ pub trait MeterProvider {
     ///
     /// If the name is empty, then an implementation defined default name will
     /// be used instead.
-    fn meter(&self, name: &'static str) -> Meter {
+    fn meter(&self, name: Cow<'static, str>) -> Meter {
         self.versioned_meter(name, None, None)
     }
 
@@ -34,9 +34,9 @@ pub trait MeterProvider {
     /// default name will be used instead.
     fn versioned_meter(
         &self,
-        name: &'static str,
-        version: Option<&'static str>,
-        schema_url: Option<&'static str>,
+        name: Cow<'static, str>,
+        version: Option<Cow<'static, str>>,
+        schema_url: Option<Cow<'static, str>>,
     ) -> Meter;
 }
 

opentelemetry-api/src/metrics/noop.rs

@@ -10,7 +10,7 @@ use crate::{
     },
     Context, KeyValue,
 };
-use std::{any::Any, sync::Arc};
+use std::{any::Any, borrow::Cow, sync::Arc};
 
 /// A no-op instance of a `MetricProvider`
 #[derive(Debug, Default)]
@@ -28,9 +28,9 @@ impl NoopMeterProvider {
 impl MeterProvider for NoopMeterProvider {
     fn versioned_meter(
         &self,
-        _name: &'static str,
-        _version: Option<&'static str>,
-        _schema_url: Option<&'static str>,
+        _name: Cow<'static, str>,
+        _version: Option<Cow<'static, str>>,
+        _schema_url: Option<Cow<'static, str>>,
     ) -> Meter {
         Meter::new(Arc::new(NoopMeterCore::new()))
     }

opentelemetry-api/src/trace/noop.rs

@@ -31,9 +31,9 @@ impl trace::TracerProvider for NoopTracerProvider {
     /// Returns a new `NoopTracer` instance.
     fn versioned_tracer(
         &self,
-        _name: impl Into<Cow<'static, str>>,
-        _version: Option<&'static str>,
-        _schema_url: Option<&'static str>,
+        _name: Cow<'static, str>,
+        _version: Option<Cow<'static, str>>,
+        _schema_url: Option<Cow<'static, str>>,
     ) -> Self::Tracer {
         NoopTracer::new()
     }

opentelemetry-api/src/trace/tracer_provider.rs

@@ -34,7 +34,7 @@ pub trait TracerProvider {
     ///     Some("https://opentelemetry.io/schema/1.0.0")
     /// );
     /// ```
-    fn tracer(&self, name: impl Into<Cow<'static, str>>) -> Self::Tracer {
+    fn tracer(&self, name: Cow<'static, str>) -> Self::Tracer {
         self.versioned_tracer(name, None, None)
     }
 
@@ -63,8 +63,8 @@ pub trait TracerProvider {
     /// ```
     fn versioned_tracer(
         &self,
-        name: impl Into<Cow<'static, str>>,
-        version: Option<&'static str>,
-        schema_url: Option<&'static str>,
+        name: Cow<'static, str>,
+        version: Option<Cow<'static, str>>,
+        schema_url: Option<Cow<'static, str>>,
     ) -> Self::Tracer;
 }

opentelemetry-jaeger/src/exporter/config/mod.rs

@@ -121,8 +121,8 @@ pub(crate) fn install_tracer_provider_and_get_tracer(
     tracer_provider: sdk::trace::TracerProvider,
 ) -> Result<sdk::trace::Tracer, TraceError> {
     let tracer = tracer_provider.versioned_tracer(
-        "opentelemetry-jaeger",
-        Some(env!("CARGO_PKG_VERSION")),
+        "opentelemetry-jaeger".into(),
+        Some(env!("CARGO_PKG_VERSION").into()),
         None,
     );
     let _ = global::set_tracer_provider(tracer_provider);

opentelemetry-sdk/src/export/trace/stdout.rs

@@ -100,7 +100,7 @@ where
         let provider = provider_builder.build();
 
         let tracer =
-            provider.versioned_tracer("opentelemetry", Some(env!("CARGO_PKG_VERSION")), None);
+            provider.versioned_tracer("opentelemetry".into(), Some(env!("CARGO_PKG_VERSION").into()), None);
         let _ = global::set_tracer_provider(provider);
 
         tracer

opentelemetry-sdk/src/metrics/meter_provider.rs

@@ -1,7 +1,10 @@
 use core::fmt;
-use std::sync::{
-    atomic::{AtomicBool, Ordering},
-    Arc,
+use std::{
+    borrow::Cow,
+    sync::{
+        atomic::{AtomicBool, Ordering},
+        Arc,
+    },
 };
 
 use opentelemetry_api::{
@@ -73,9 +76,9 @@ impl MeterProvider {
 impl opentelemetry_api::metrics::MeterProvider for MeterProvider {
     fn versioned_meter(
         &self,
-        name: &'static str,
-        version: Option<&'static str>,
-        schema_url: Option<&'static str>,
+        name: Cow<'static, str>,
+        version: Option<Cow<'static, str>>,
+        schema_url: Option<Cow<'static, str>>,
     ) -> ApiMeter {
         let inst_provider: Arc<dyn InstrumentProvider + Send + Sync> =
             if !self.is_shutdown.load(Ordering::Relaxed) {

opentelemetry-sdk/src/trace/provider.rs

@@ -122,22 +122,17 @@ impl opentelemetry_api::trace::TracerProvider for TracerProvider {
     /// Create a new versioned `Tracer` instance.
     fn versioned_tracer(
         &self,
-        name: impl Into<Cow<'static, str>>,
-        version: Option<&'static str>,
-        schema_url: Option<&'static str>,
+        name: Cow<'static, str>,
+        version: Option<Cow<'static, str>>,
+        schema_url: Option<Cow<'static, str>>,
     ) -> Self::Tracer {
-        let name = name.into();
         // Use default value if name is invalid empty string
         let component_name = if name.is_empty() {
             Cow::Borrowed(DEFAULT_COMPONENT_NAME)
         } else {
             name
         };
-        let instrumentation_lib = InstrumentationLibrary::new(
-            component_name,
-            version.map(Into::into),
-            schema_url.map(Into::into),
-        );
+        let instrumentation_lib = InstrumentationLibrary::new(component_name, version, schema_url);
 
         Tracer::new(instrumentation_lib, Arc::downgrade(&self.inner))
     }