Use the browser-only js-sys workaround only when actually targeting a browser (#1005) #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… browser (#1005) wasi runtimes do provide a SystemTime implementation, see https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/clocks.rs
|
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #1008 +/- ##
=====================================
Coverage 69.9% 69.9%
=====================================
Files 116 116
Lines 9027 9026 -1
=====================================
Hits 6316 6316
+ Misses 2711 2710 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
djc
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasi runtimes do provide a SystemTime implementation, see
https://github.com/bytecodealliance/wasmtime/blob/main/crates/wasi-common/src/clocks.rs