-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OTLP HTTP Log Exporter example using tracing appender. #1294
Conversation
Codecov ReportAttention:
... and 1 file with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this. Just one nit which would be nice to address before merging...
The CI is failing with:
Does it mean we should bump up msrv to 1.65.0 ? |
opentelemetry-otlp/examples/basic-otlp-http/docker-compose.yaml
Outdated
Show resolved
Hide resolved
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
@jtescher @TommyCpp Seems the PRs are blocked on this error. Should we raise a separate PR to bump the msrv version ? |
Changes
Update the existing OTLP HTTP exporter to export logs instrumented through tokio library, using tracing appender. This change could have suffered from infinite live-loop issue described in Need a way to suppress telemetry from SDKs own operation #1171, but the Hyper HTTP library emits tracing/debug logs only if the tracing feature (which is disabled by default) is enabled for this library, and Cargo.toml for this example doesn't enable it. Also, there are no errors reported from this library (which would also get routed to OpenTelemetry appender) if the steps in examples are executed properly. So only the logs, traces and metrics geerated from the example code are exported to the collector.
Also for simplicity removed all-in-one jaeger exporter from the collector configuration, and instead used Debug Exporter which dumps all events to console.
The infinite live-issue discussed in Need a way to suppress telemetry from SDKs own operation #1171 need to be investigated separately, one option could be to filter all such non-required events using
event_enabled
function by checking the target/module.Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes