Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add custom serde encoding/decoding for timestamp #1666

Merged
merged 8 commits into from
Apr 17, 2024
Merged

Add custom serde encoding/decoding for timestamp #1666

merged 8 commits into from
Apr 17, 2024

Conversation

lalitb
Copy link
Member

@lalitb lalitb commented Apr 17, 2024 •
edited
Loading

Fixes #1662

Changes

Add a special serde serializer/deserializer for the timestamp. As timestamp is uint64, and int64, fixed64, uint64 should be serialized as string in json

Merge requirement checklist

  • CONTRIBUTING guidelines followed
  • Unit tests added/updated (if applicable)
  • Appropriate CHANGELOG.md files updated for non-trivial, user-facing changes
  • Changes in public API reviewed (if applicable)

@lalitb lalitb requested a review from a team April 17, 2024 01:34
@lalitb lalitb marked this pull request as draft April 17, 2024 02:06
@lalitb lalitb marked this pull request as ready for review April 17, 2024 07:02
@cijothomas cijothomas merged commit 758cdd7 into open-telemetry:main Apr 17, 2024
14 of 15 checks passed
@lalitb lalitb mentioned this pull request May 13, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyCpp TommyCpp TommyCpp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Cannot decode opentelemetry-collector exported trace data
3 participants
@lalitb @TommyCpp @cijothomas