[tracing appender] Collect span attributes #1692
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems related to #1378
Changes
Currently, span attributes are not collected by the
OpenTelemetryTracingBridge
. E.g. when usingthis will emit the log message with attribute
baz = 42
, but withoutfoo = bar
.It can still be desirable to emit attribute values, e.g. when not correlating to emitted tracing data.
This PR adds such functionality by adding two flags that control if span attributes are emitted with logs, and if so, if they are flattened or nested.
Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes