Flatten field + fix u64 to string serde #1911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR:
data
andvalue
fields in order to be consistent with the JSON schema implemented on the OTEL Collectoru64
andString
./expected/metrics.json
file wouldn't even deserialize correctly.Testing
cargo test --workspace --all-features --test grpc_build -- --nocapture
to generate grpc files. Running the first time is expected to fail, as it will create the files.cargo test --workspace --all-features --test metrics 'test_serde' -- --nocapture
to run the new test case introduced in this PR.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changescc @lalitb