Add InstrumentationLibrary for instrumentation library information #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntation library information. * Fix problem that our instrumentation libraries only have name but don't have version
|
I think a second method may be more ergonomic, many people don't even like having to specify the first argument as brought up in open-telemetry/opentelemetry-specification#586. |
Make sense. Will add another method in |
|
Hm seems less critical as people are less likely to use |
If there is no version provided, we should probably just leave it to None instead of put a empty string there.
In most of the case, user wouldn't use version of instrumentation library. So it's best to by default allow user to get a tracer with only name. Add another `trace_with_version` method so that if users want to, they can get a tracer with name and version information.
TommyCpp
force-pushed
the
instrumentation-library
branch
from
526198d
to
e575eda
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #204
As per spec, we should provide an optional param for version in
TraceProvider::get_tracer. I think we should stick with spec and add second param here.But it feels like most of the time people won't use it. So we maybe able to provide
global::tracerandglobal::tracer_with_versionmethods so that users won't need to typeNoneeverytime when they retrive a tracer.Not sure if it's desired, so I added second param into
global::tracerfor now.