PeriodicReader::build make interval registration in same thread/task #2133
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Previous behavior was that in
PeriodicReader::build
interval was registered before spawning a task. Which means that we effectively need already running runtime in order to register aninterval
.This revision moves
interval
registration withinspawn
function, which allow to registerPeriodicReader
independently of any runtime.You can see in test
collection_triggered_by_interval
, that this works perfectly fine without any runtime when usingTokioCurrentThread
.Merge requirement checklist
CHANGELOG.md
files updated for non-trivial, user-facing changes