-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
resources map to jaeger process tags #215
resources map to jaeger process tags #215
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good start, thanks! have some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the late reply. LGTM. Thanks!
@danrusei generally looks good, just want to make sure this won't add duplicate process tags when exporting batches of spans |
thank you, would this work ?
|
@danrusei That should work but it may do a lot of work checking each time. The resource should be the same for all spans, so you could do something like |
Looks good @danrusei, just have to rebase and make sure tests pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good thanks @danrusei
#205
I hope my understanding about what is requested here is correct, otherwise I'll modify based on the feedback.