Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resources map to jaeger process tags #215

Merged
merged 1 commit into from
Sep 20, 2020
Merged

resources map to jaeger process tags #215

merged 1 commit into from
Sep 20, 2020

Conversation

danrusei
Copy link
Contributor

@danrusei danrusei commented Sep 8, 2020

#205
I hope my understanding about what is requested here is correct, otherwise I'll modify based on the feedback.

@danrusei danrusei requested a review from a team September 8, 2020 07:19
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Sep 8, 2020

CLA Check
The committers are authorized under a signed CLA.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start, thanks! have some suggestions

opentelemetry-jaeger/src/lib.rs Outdated Show resolved Hide resolved
opentelemetry-jaeger/src/lib.rs Outdated Show resolved Hide resolved
opentelemetry-jaeger/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. LGTM. Thanks!

@jtescher
Copy link
Member

@danrusei generally looks good, just want to make sure this won't add duplicate process tags when exporting batches of spans

@danrusei
Copy link
Contributor Author

@danrusei generally looks good, just want to make sure this won't add duplicate process tags when exporting batches of spans

thank you, would this work ?

for tag in build_process_tags(&span) {
                    if !process_tags.contains(&tag) {
                        process_tags.push(tag)
                    }
                }                

@jtescher
Copy link
Member

jtescher commented Sep 17, 2020

@danrusei That should work but it may do a lot of work checking each time. The resource should be the same for all spans, so you could do something like for (idx, span) in spans.enumerate() { if idx == 0 { add tags} ... } to only add them the first time?

@jtescher
Copy link
Member

Looks good @danrusei, just have to rebase and make sure tests pass

Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks @danrusei

@jtescher jtescher merged commit 076dd2e into open-telemetry:master Sep 20, 2020
@danrusei danrusei deleted the resources_to_jaeger_process branch September 21, 2020 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants