Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PeriodicReader with own Thread the default #2403

Merged

Conversation

cijothomas
Copy link
Member

@cijothomas cijothomas commented Dec 10, 2024

Metrics/PeriodicReader part of #2386

  1. Makes PeriodicReaderWithOwnThread as the default PeriodicReader
  2. The existing PeriodicReader that required runtime is now enabled under flag "experimental_metrics_periodicreader_with_async_runtime". Existing functionality retained as-is, just under a feature flag and module name.
  3. Modified examples to use the default PeriodicReader.
  4. Otlp-Basic-Http does not yet work with PeriodicReader as reqwest client it uses needs tokio runtime. This example is retained as-is, demonstrating that existing functionality can be retained as-is by adding "experimental_metrics_periodicreader_with_async_runtime" feature.

@cijothomas cijothomas requested a review from a team as a code owner December 10, 2024 02:27
@cijothomas cijothomas added the integration tests Run integration tests label Dec 10, 2024
Copy link

codecov bot commented Dec 10, 2024

Codecov Report

Attention: Patch coverage is 84.42136% with 105 lines in your changes missing coverage. Please review.

Project coverage is 79.2%. Comparing base (d67d1fc) to head (eedc07e).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../src/metrics/periodic_reader_with_async_runtime.rs 76.3% 63 Missing ⚠️
opentelemetry-sdk/src/metrics/periodic_reader.rs 89.7% 41 Missing ⚠️
opentelemetry-sdk/src/metrics/mod.rs 87.5% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #2403     +/-   ##
=======================================
- Coverage   79.4%   79.2%   -0.3%     
=======================================
  Files        123     123             
  Lines      21527   21527             
=======================================
- Hits       17111   17065     -46     
- Misses      4416    4462     +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cijothomas
Copy link
Member Author

Merging to make progress, happy to address feedbacks post merger.

@cijothomas cijothomas merged commit 238a8f2 into open-telemetry:main Dec 11, 2024
23 checks passed
@cijothomas cijothomas deleted the cijothomas/periodicreader-defaults branch December 11, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration tests Run integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants