Skip to content

Conversation

@cijothomas
Copy link
Member

Remove individual LICENSE files from all crates since they are redundant with the license = "Apache-2.0" field in each Cargo.toml.

  • Removed LICENSE files from 12 individual crates
  • Kept root LICENSE file and proto LICENSE file (from upstream)
  • All crates retain license = "Apache-2.0" in their Cargo.toml

The license field in Cargo.toml is the recommended approach for well-known licenses like Apache-2.0, and Cargo will properly handle license information when publishing to crates.io.
https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields

@cijothomas cijothomas requested a review from a team as a code owner July 26, 2025 01:40
@codecov
Copy link

codecov bot commented Jul 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.1%. Comparing base (e9ca158) to head (9edc74d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #3086   +/-   ##
=====================================
  Coverage   80.1%   80.1%           
=====================================
  Files        126     126           
  Lines      21957   21957           
=====================================
+ Hits       17603   17604    +1     
+ Misses      4354    4353    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cijothomas cijothomas changed the title Remove redundant LICENSE files from individual crates chore: Remove redundant LICENSE files from individual crates Jul 26, 2025
@cijothomas cijothomas requested a review from Copilot July 26, 2025 02:04
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up the license structure by removing redundant LICENSE files from individual crates while retaining license metadata in Cargo.toml files.

  • Removed 12 individual LICENSE files from various OpenTelemetry crates
  • Maintained license information through license = "Apache-2.0" field in Cargo.toml
  • Streamlined license management to use Cargo's recommended approach for well-known licenses

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
opentelemetry/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-zipkin/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-stdout/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-semantic-conventions/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-sdk/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-proto/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-prometheus/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-otlp/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-jaeger-propagator/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-http/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-appender-tracing/LICENSE Removed redundant Apache-2.0 license file
opentelemetry-appender-log/LICENSE Removed redundant Apache-2.0 license file

@TommyCpp TommyCpp merged commit 42139cb into open-telemetry:main Jul 28, 2025
27 of 28 checks passed
@cijothomas cijothomas deleted the cijothomas/licensecleanups branch July 28, 2025 16:57
bantonsson pushed a commit to bantonsson/opentelemetry-rust that referenced this pull request Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants