Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move HTTP-related code into a separate crate #415

Merged
merged 6 commits into from
Jan 14, 2021
Merged

Move HTTP-related code into a separate crate #415

merged 6 commits into from
Jan 14, 2021

Conversation

djc
Copy link
Contributor

@djc djc commented Jan 5, 2021

See #403.

@djc djc requested a review from a team January 5, 2021 14:46
@djc djc force-pushed the no-http branch 2 times, most recently from 8fd5e99 to f8b9ca1 Compare January 5, 2021 15:14
@codecov
Copy link

codecov bot commented Jan 5, 2021 •
edited
Loading

Codecov Report

Merging #415 (1f810eb) into master (fc3175f) will increase coverage by 3.24%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #415      +/-   ##
==========================================
+ Coverage   48.32%   51.57%   +3.24%     
==========================================
  Files          65       65              
  Lines        5502     5117     -385     
==========================================
- Hits         2659     2639      -20     
+ Misses       2843     2478     -365
Impacted Files Coverage Δ
opentelemetry/src/metrics/mod.rs 0.00% <0.00%> (ø)
opentelemetry/src/propagation/mod.rs 100.00% <ø> (ø)
opentelemetry/src/sdk/export/trace/mod.rs 98.11% <ø> (+41.59%) ⬆️
opentelemetry/src/trace/mod.rs 0.00% <0.00%> (ø)
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.95% <0.00%> (+0.19%) ⬆️
opentelemetry/src/context.rs 32.23% <0.00%> (+0.21%) ⬆️
opentelemetry/src/core.rs 57.14% <0.00%> (+2.52%) ⬆️
opentelemetry-otlp/src/span.rs 33.33% <0.00%> (+30.72%) ⬆️
opentelemetry/src/sdk/instrumentation.rs 50.00% <0.00%> (+50.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc3175f...1f810eb. Read the comment docs.

@djc djc force-pushed the no-http branch 3 times, most recently from 3fffe93 to 83efe2c Compare January 5, 2021 16:19
@djc djc mentioned this pull request Jan 5, 2021
Closed
jtescher
jtescher approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@jtescher jtescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtescher
Copy link
Member

jtescher commented Jan 5, 2021

Can add the usual crate files license, readme, etc as well or in a follow up pr

@djc djc force-pushed the no-http branch 2 times, most recently from 7eaa612 to 2f37f91 Compare January 5, 2021 20:33
@djc djc force-pushed the no-http branch 2 times, most recently from 54f4914 to 6eb035b Compare January 6, 2021 07:29
TommyCpp
TommyCpp approved these changes Jan 6, 2021
View reviewed changes
Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Thanks a lot

@jtescher jtescher merged commit b2ab799 into open-telemetry:master Jan 14, 2021
@djc djc mentioned this pull request Feb 8, 2021
Merged
@djc djc mentioned this pull request Mar 25, 2024
Closed
@holmofy holmofy mentioned this pull request Oct 13, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TommyCpp TommyCpp TommyCpp approved these changes

@jtescher jtescher jtescher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@djc @jtescher @TommyCpp