-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure tls and add example for grpcio #450
Configure tls and add example for grpcio #450
Conversation
Codecov Report
@@ Coverage Diff @@
## main #450 +/- ##
==========================================
+ Coverage 47.91% 48.43% +0.52%
==========================================
Files 95 95
Lines 8739 8739
==========================================
+ Hits 4187 4233 +46
+ Misses 4552 4506 -46
Continue to review full report at Codecov.
|
Might need to remove the example from the workspace and ask CI to check it separately. |
should I do it only on this example or for all of them? |
8e85dcf
to
321717f
Compare
ecbdfda
to
8c8be77
Compare
8c8be77
to
3e98816
Compare
Looks reasonable, thanks |
This PR adds a new function to otlp's builder called
with_tls
in order to configure empty credentials on grpcio so it talks with https and not in a decrypted manner.I think that for the future this with_tls could be used on tonic as well so it can configure the host for TLS in case the server you are talking to uses SNI.
Let me know if you have questions or something has o change there.