Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure tls and add example for grpcio #450

Merged
merged 6 commits into from
Feb 13, 2021

Conversation

jaysonsantos
Copy link
Contributor

This PR adds a new function to otlp's builder called with_tls in order to configure empty credentials on grpcio so it talks with https and not in a decrypted manner.
I think that for the future this with_tls could be used on tonic as well so it can configure the host for TLS in case the server you are talking to uses SNI.
Let me know if you have questions or something has o change there.

@jaysonsantos jaysonsantos requested a review from a team February 6, 2021 21:50
@codecov
Copy link

codecov bot commented Feb 6, 2021

Codecov Report

Merging #450 (c0060c1) into main (8e0857d) will increase coverage by 0.52%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #450      +/-   ##
==========================================
+ Coverage   47.91%   48.43%   +0.52%     
==========================================
  Files          95       95              
  Lines        8739     8739              
==========================================
+ Hits         4187     4233      +46     
+ Misses       4552     4506      -46     
Impacted Files Coverage Δ
opentelemetry-otlp/src/span.rs 17.77% <0.00%> (ø)
...ntelemetry/src/sdk/metrics/aggregators/ddsketch.rs 76.95% <0.00%> (ø)
opentelemetry/src/context.rs 62.09% <0.00%> (+30.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8e0857d...c0060c1. Read the comment docs.

@TommyCpp
Copy link
Contributor

TommyCpp commented Feb 9, 2021

Might need to remove the example from the workspace and ask CI to check it separately.

@jaysonsantos
Copy link
Contributor Author

@TommyCpp

Might need to remove the example from the workspace and ask CI to check it separately.

should I do it only on this example or for all of them?

@jaysonsantos jaysonsantos force-pushed the external-tolp-grcpio branch 2 times, most recently from 8e85dcf to 321717f Compare February 10, 2021 09:14
@jaysonsantos jaysonsantos force-pushed the external-tolp-grcpio branch 3 times, most recently from ecbdfda to 8c8be77 Compare February 11, 2021 20:46
@jtescher
Copy link
Member

Looks reasonable, thanks

@jtescher jtescher merged commit 2269d1f into open-telemetry:main Feb 13, 2021
@jaysonsantos jaysonsantos deleted the external-tolp-grcpio branch February 14, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants