Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make SpanRef public #600

Merged
merged 1 commit into from
Jul 23, 2021
Merged

Conversation

ramosbugs
Copy link
Contributor

#505 improved local span performance by moving the mutex into the
Context (via SynchronizedSpan) and introduced a SpanRef type
returned by TraceContextExt::span(). However, SpanRef is not currently
exported via the public API, which precludes passing it around easily within
client code. This PR exports that type alongside TraceContextExt.

@ramosbugs ramosbugs requested a review from a team July 23, 2021 00:07
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jul 23, 2021

CLA Signed

The committers are authorized under a signed CLA.

Copy link
Contributor

@TommyCpp TommyCpp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Thanks

@codecov
Copy link

codecov bot commented Jul 23, 2021

Codecov Report

Merging #600 (47079b2) into main (55d798e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #600   +/-   ##
=====================================
  Coverage   55.0%   55.0%           
=====================================
  Files        100     100           
  Lines       8890    8890           
=====================================
  Hits        4895    4895           
  Misses      3995    3995           
Impacted Files Coverage Δ
opentelemetry/src/trace/mod.rs 71.1% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d798e...47079b2. Read the comment docs.

@TommyCpp TommyCpp merged commit 197c388 into open-telemetry:main Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants