Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix dead link in datadog, use Cow<'static, str> in in_span function, updated protos generated files #720

Merged
merged 3 commits into from
Feb 6, 2022

Conversation

TommyCpp
Copy link
Contributor

@TommyCpp TommyCpp commented Feb 5, 2022

Fix #715, fix #717.

This should fix the build failure in the main branch.

Follow up on #654, #716

@TommyCpp TommyCpp changed the title fix dead link in datadog, use Cow<'static, str> in in_span function, updated protos fix dead link in datadog, use Cow<'static, str> in in_span function, updated protos generated files Feb 5, 2022
@codecov
Copy link

codecov bot commented Feb 5, 2022

Codecov Report

Merging #720 (4f49f9b) into main (308b60a) will increase coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
+ Coverage   71.37%   71.40%   +0.03%     
==========================================
  Files         101      101              
  Lines        8554     8554              
==========================================
+ Hits         6105     6108       +3     
+ Misses       2449     2446       -3     
Impacted Files Coverage Δ
opentelemetry/src/trace/tracer.rs 60.60% <0.00%> (ø)
opentelemetry-http/src/lib.rs 12.28% <0.00%> (+5.26%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308b60a...4f49f9b. Read the comment docs.

@TommyCpp TommyCpp marked this pull request as ready for review February 5, 2022 21:42
@TommyCpp TommyCpp requested a review from a team February 5, 2022 21:42
@TommyCpp TommyCpp merged commit 28d13fb into open-telemetry:main Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

span name requires static string dead link
2 participants