-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msrv: bump from 1.49 to 1.55 #811
Conversation
Codecov Report
@@ Coverage Diff @@
## main #811 +/- ##
=====================================
Coverage 69.8% 69.8%
=====================================
Files 110 110
Lines 9072 9072
=====================================
+ Hits 6334 6337 +3
+ Misses 2738 2735 -3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may still want to support 1.49 as many people integrate via tracing
https://github.com/tokio-rs/tracing/tree/master/tracing#supported-rust-versions
Which changes would we need to revert to continue supporting 1.49? |
The bump was introduced by #799. I think alternatively we can rewrite part of the Although Tokio ecosystem promise 6-month compatibility. 1.55 was released in Sep 2021 so it's still consistent with that promise. Any thoughts? |
Nvm we could open an issue to bump tracing as well, but probably simpler to retain 1.49 support if we can't get that in. |
I will give it a try! I will merge this for now so that we can maintain at least 1.55 MSRV when building the new PRs. The current one in main branch breaks our MSRV promise. |
async-std
version to1.8
as any version >1.8
will requires rustc 1.59 support, which breaks our MSRV guarantee. Ideally we should revert this change once Restore num_cpus and reduce MSRV? async-rs/async-global-executor#10 resolves and the new version releases