Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jaeger): reqwest client runs inside a non-tokio runtime #829

Merged
merged 4 commits into from
Jul 4, 2022

Conversation

TommyCpp
Copy link
Contributor

Fix #812

We didn't pass the runtime into the exporter, which caused the reqwest to fail to run. This PR fixes this by splitting the exporter creation tasks in async and sync.

Since we don't return async tasks handle when spawn them from Runtime implementation the shutdown will not block now.

This is a temporary fix, in the long term we should probably split the jaeger exporter using async and sync. More discussion can be found in #781 (comment)

@codecov
Copy link

codecov bot commented Jun 30, 2022

Codecov Report

Merging #829 (ba999ab) into main (103ed3a) will increase coverage by 0.0%.
The diff coverage is 85.7%.

@@          Coverage Diff          @@
##            main    #829   +/-   ##
=====================================
  Coverage   69.8%   69.8%           
=====================================
  Files        111     111           
  Lines       9196    9191    -5     
=====================================
+ Hits        6420    6423    +3     
+ Misses      2776    2768    -8     
Impacted Files Coverage Δ
...emetry-jaeger/src/exporter/config/collector/mod.rs 57.9% <ø> (ø)
opentelemetry-jaeger/src/exporter/config/agent.rs 57.4% <50.0%> (ø)
opentelemetry-jaeger/src/exporter/mod.rs 53.8% <100.0%> (+2.8%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 103ed3a...ba999ab. Read the comment docs.

@TommyCpp TommyCpp marked this pull request as ready for review June 30, 2022 16:09
@TommyCpp TommyCpp requested a review from a team June 30, 2022 16:09
@jtescher jtescher merged commit 20e46ee into open-telemetry:main Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants