fix(jaeger): reqwest client runs inside a non-tokio runtime #829
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #812
We didn't pass the runtime into the exporter, which caused the
reqwest
to fail to run. This PR fixes this by splitting the exporter creation tasks in async and sync.Since we don't return async tasks handle when spawn them from
Runtime
implementation theshutdown
will not block now.This is a temporary fix, in the long term we should probably split the jaeger exporter using async and sync. More discussion can be found in #781 (comment)