Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tonic -> 0.8.0 #859

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Update tonic -> 0.8.0 #859

merged 2 commits into from
Aug 10, 2022

Conversation

realtimetodie
Copy link
Contributor

@realtimetodie realtimetodie requested a review from a team August 7, 2022 19:46
@djc
Copy link
Contributor

djc commented Aug 8, 2022

Thanks for working on this! Changes look good so far, though I guess there's some more work to do before CI passes.

@realtimetodie realtimetodie force-pushed the tonic-update branch 2 times, most recently from cc21dc5 to ca7bff1 Compare August 9, 2022 11:49
@realtimetodie
Copy link
Contributor Author

Some CI tests are flaky.

@djc
Copy link
Contributor

djc commented Aug 9, 2022

Feel free to ignore the coverage test, and it looks like we have to bump the MSRV again. Feel free to ignore those!

djc
djc approved these changes Aug 9, 2022
View reviewed changes
Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@TommyCpp TommyCpp merged commit aec7d0b into open-telemetry:main Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@realtimetodie @djc @TommyCpp