Skip to content

Commit

Permalink
Fix last feedback, allow this to be a class or not
Browse files Browse the repository at this point in the history
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
  • Loading branch information
bogdandrutu committed Feb 10, 2021
1 parent 06a249b commit 05c9f5a
Showing 1 changed file with 4 additions and 7 deletions.
11 changes: 4 additions & 7 deletions specification/trace/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,10 @@ It the SDK implements the limits above it MUST provide a way to change these
limits, via a configuration to the TracerProvider, by allowing users to
configure individual limits like in the Java example bellow.

The name of the configuration class MAY be `SpanLimits`, and the
name of the properties SHOULD be `AttributeCountLimit`, `EventCountLimit` and
`LinkCountLimit`. Implementations MAY provide additional configuration such as
`AttributePerEventCountLimit` and `AttributePerLinkCountLimit`.
The name of the configuration options SHOULD be `AttributeCountLimit`,
`EventCountLimit` and `LinkCountLimit`. The options MAY be bundled in a class,
which then SHOULD be called `SpanLimits`. Implementations MAY provide additional
configuration such as `AttributePerEventCountLimit` and `AttributePerLinkCountLimit`.

```java
public final class SpanLimits {
Expand All @@ -332,9 +332,6 @@ public final class SpanLimits {
* `AttributePerEventCountLimit` (Default=128) - Maximum allowed attribute per span event count;
* `AttributePerLinkCountLimit` (Default=128) - Maximum allowed attribute per span link count;

If there is a configuration provided, the SDK SHOULD honor the environment variables
specified in [SDK environment variables](../sdk-environment-variables.md#span-collection-limits).

There SHOULD be a log emitted to indicate to the user that an attribute, event,
or link was discarded due to such a limit. To prevent excessive logging, the log
should not be emitted once per span, or per discarded attribute, event, or links.
Expand Down

0 comments on commit 05c9f5a

Please sign in to comment.