Skip to content

Commit

Permalink
Clarify cardinality capping should be after filtering (#4228)
Browse files Browse the repository at this point in the history
  • Loading branch information
cijothomas committed Sep 27, 2024
1 parent 6ed9226 commit 0e78770
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@ release.
([#4211](https://github.com/open-telemetry/opentelemetry-specification/pull/4211))
- Make all fields as identifying for Meter. Previously attributes were omitted from being identifying.
([#4161](https://github.com/open-telemetry/opentelemetry-specification/pull/4161))
- Clarify that applying cardinality limits should be done after attribute filtering.
([#4228](https://github.com/open-telemetry/opentelemetry-specification/pull/4228))

### Logs

Expand Down
4 changes: 3 additions & 1 deletion specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -780,7 +780,9 @@ SDKs SHOULD support being configured with a cardinality limit. The number of
unique combinations of attributes is called cardinality. For a given metric, the
cardinality limit is a hard limit on the number of [Metric
Points](./data-model.md#metric-points) that can be collected during a collection
cycle.
cycle. Cardinality limit enforcement SHOULD occur _after_ attribute filtering,
if any. This ensures users can filter undesired attributes using [views](#view)
and prevent reaching the cardinality limit.

#### Configuration

Expand Down

0 comments on commit 0e78770

Please sign in to comment.