Skip to content

Commit

Permalink
Merge branch 'open-telemetry:main' into MSNev/EventData
Browse files Browse the repository at this point in the history
  • Loading branch information
MSNev authored Mar 21, 2023
2 parents 5811a9c + e7a555a commit 373d561
Show file tree
Hide file tree
Showing 6 changed files with 23 additions and 3 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,16 @@ release.

### Semantic Conventions

- Clarify that attribute requirement levels apply to the instrumentation library
([#3289](https://github.com/open-telemetry/opentelemetry-specification/pull/3289))
- Fix grammatical number of metric units.
([#3298](https://github.com/open-telemetry/opentelemetry-specification/pull/3298))
- Rename `net.app.protocol.(name|version)` to `net.protocol.(name|version)`
([#3272](https://github.com/open-telemetry/opentelemetry-specification/pull/3272))
- Replace `http.flavor` with `net.protocol.(name|version)`
([#3272](https://github.com/open-telemetry/opentelemetry-specification/pull/3272))
- Metric requirement levels are now stable
([#3271](https://github.com/open-telemetry/opentelemetry-specification/pull/3271))

### Compatibility

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"devDependencies": {
"markdown-link-check": "^3.9.3",
"markdown-link-check": "3.10.3",
"markdown-toc": "^1.2.0",
"markdownlint-cli": "0.31.0"
}
Expand Down
2 changes: 1 addition & 1 deletion spec-compliance-matrix.md
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ formats is required. Implementing more than one format is optional.
| RecordException | | - | + | + | + | + | + | + | + | - | + | - |
| RecordException with extra parameters | | - | + | + | + | + | + | + | + | - | + | - |
| [Sampling](specification/trace/sdk.md#sampling) | Optional | Go | Java | JS | Python | Ruby | Erlang | PHP | Rust | C++ | .NET | Swift |
| Allow samplers to modify tracestate | | + | + | | + | + | + | + | + | + | - | + |
| Allow samplers to modify tracestate | | + | + | | + | + | + | + | + | + | + | + |
| ShouldSample gets full parent Context | | + | + | + | + | + | + | + | + | + | - | + |
| Sampler: JaegerRemoteSampler | | + | + | | | | | | + | | | |
| [New Span ID created also for non-recording Spans](specification/trace/sdk.md#sdk-span-creation) | | + | + | | + | + | + | + | + | + | - | + |
Expand Down
2 changes: 2 additions & 0 deletions specification/common/attribute-requirement-level.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@

_This section applies to Log, Metric, Resource, and Span, and describes requirement levels for attributes defined in semantic conventions._

Attribute requirement levels apply to the [instrumentation library](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/glossary.md#instrumentation-library).

The following attribute requirement levels are specified:

- [Required](#required)
Expand Down
2 changes: 1 addition & 1 deletion specification/metrics/metric-requirement-level.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Metric Requirement Levels for Semantic Conventions

**Status**: [Experimental](../document-status.md)
**Status**: [Stable](../document-status.md)

<details>
<summary>Table of Contents</summary>
Expand Down
14 changes: 14 additions & 0 deletions specification/metrics/semantic_conventions/http-metrics.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,20 @@ operations. By adding HTTP attributes to metric events it allows for finely tune

**Disclaimer:** These are initial HTTP metric instruments and attributes but more may be added in the future.

<!-- toc -->

- [HTTP Server](#http-server)
* [Metric: `http.server.duration`](#metric-httpserverduration)
* [Metric: `http.server.active_requests`](#metric-httpserveractive_requests)
* [Metric: `http.server.request.size`](#metric-httpserverrequestsize)
* [Metric: `http.server.response.size`](#metric-httpserverresponsesize)
- [HTTP Client](#http-client)
* [Metric: `http.client.duration`](#metric-httpclientduration)
* [Metric: `http.client.request.size`](#metric-httpclientrequestsize)
* [Metric: `http.client.response.size`](#metric-httpclientresponsesize)

<!-- tocstop -->

## HTTP Server

### Metric: `http.server.duration`
Expand Down

0 comments on commit 373d561

Please sign in to comment.