Skip to content

Commit

Permalink
Clarify ShouldSample returned attributes constrains (#835)
Browse files Browse the repository at this point in the history
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
  • Loading branch information
bogdandrutu authored Aug 21, 2020
1 parent b409fb1 commit 63cc900
Showing 1 changed file with 2 additions and 4 deletions.
6 changes: 2 additions & 4 deletions specification/trace/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -81,10 +81,8 @@ It produces an output called `SamplingResult` which contains:
will be dropped.
* `RECORD` - `IsRecording() == true`, but `Sampled` flag MUST NOT be set.
* `RECORD_AND_SAMPLED` - `IsRecording() == true` AND `Sampled` flag` MUST be set.
* A set of span Attributes that will also be added to the `Span`.
* The list of attributes returned by `SamplingResult` MUST be immutable.
Caller may call this method any number of times and can safely cache the
returned value.
* A set of span Attributes that will also be added to the `Span`. The returned
object must be immutable (multiple calls may return different immutable objects).

#### GetDescription

Expand Down

0 comments on commit 63cc900

Please sign in to comment.